-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(processWorker): create process worker package #998
base: main
Are you sure you want to change the base?
Conversation
src/framework/Framework.Processes.Library/Entities/ProcessStepStatus.cs
Fixed
Show resolved
Hide resolved
src/framework/Framework.Processes.Library/ManualProcessStepDataExtensions.cs
Fixed
Show fixed
Hide fixed
src/portalbackend/PortalBackend.DBAccess/Repositories/OfferSubscriptionsRepository.cs
Fixed
Show fixed
Hide fixed
src/portalbackend/PortalBackend.DBAccess/Repositories/OfferSubscriptionsRepository.cs
Fixed
Show fixed
Hide fixed
src/portalbackend/PortalBackend.DBAccess/Repositories/ServiceAccountRepository.cs
Fixed
Show fixed
Hide fixed
src/portalbackend/PortalBackend.PortalEntities/Entities/ProcessStepType.cs
Dismissed
Show resolved
Hide resolved
src/portalbackend/PortalBackend.PortalEntities/Entities/ProcessType.cs
Dismissed
Show resolved
Hide resolved
src/processes/ApplicationChecklist.Executor/ApplicationChecklistProcessTypeExecutor.cs
Fixed
Show fixed
Hide fixed
src/processes/OfferSubscription.Library/OfferSubscriptionProcessService.cs
Fixed
Show fixed
Hide fixed
c37c866
to
277d39f
Compare
a33c0d3
to
4873665
Compare
b6cdc0d
to
365e03c
Compare
365e03c
to
9e89db9
Compare
0823f7d
to
8f3b6bd
Compare
8f3b6bd
to
8e516b6
Compare
tests/processes/OfferSubscription.Library.Tests/OfferSubscriptionProcessServiceTests.cs
Fixed
Show fixed
Hide fixed
8e516b6
to
1b42399
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see everything works like before and my tests succeeded.
Some code changes were reviewed by me (not 13k) and look fine. Please test jobs after deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generaly speaking as c# inheritance is limited to a single base-type it is not advisable to mandatory enforce inheritance from a framework type. Instead interfaces should be used.
In respect to EF using concrete entity-types and dbcontext base class defines hardcoded table-names that cannot be adjusted by the framework-using code. It implies an application cannot have more than a single process/process-step table within a given db-schema. In addition to that it also disallows to define any other custom base-class for the dbcontext.
Instead the framework should define interfaces to be implemented by the concrete entities (Process, ProcessStep and ProcessStepStatus) and those interfaces should be used within the framework code.
Concrete Entity-classes implementing those interfaces and dbcontext base class may still be provided (in a separate implementation package) but the use of those should be optional.
0675335
to
d579e25
Compare
src/framework/Framework.Processes.Library.Concrete/Entities/ProcessStepStatus.cs
Dismissed
Show dismissed
Hide dismissed
src/framework/Framework.Processes.Library/Extensions/ManualProcessStepDataExtensions.cs
Fixed
Show fixed
Hide fixed
f7f0bc0
to
00e880d
Compare
allow multiple process-tables per db-schema move process-repository-code to reusable library
00e880d
to
205b709
Compare
Quality Gate passedIssues Measures |
Description
Why
To provide the process worker functionality to other products as well
Issue
#240
Checklist